<div dir="ltr">ping </div><div class="gmail_extra"> <div class="gmail_quote">On Fri, Nov 8, 2013 at 9:03 PM, Marc-André Lureau <<a href="mailto:marcandre.lureau@gmail.com" target="_blank">marcandre.lureau@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">When upgrading virt-viewer, a few files are missing. After repair, they are all back again. The reason for this is explained by the so called Component Rules, that can be simplified by use "one file per component and stable id". msitools stable component id was a bit buggy, and is now fixed in upstream (since v0.93-18-ge395249) Furthermore, although it's not mandatory for simple cases, RemoveExistingProducts should be Schedule='afterInstallFinalize', see also: <a href="http://msdn.microsoft.com/en-us/library/aa371197%28v=vs.85%29.aspx" target="_blank">http://msdn.microsoft.com/en-us/library/aa371197%28v=vs.85%29.aspx</a> <a href="http://stackoverflow.com/questions/15138731/wix-major-upgrade-not-installing-all-files" target="_blank">http://stackoverflow.com/questions/15138731/wix-major-upgrade-not-installing-all-files</a> --- data/<a href="http://virt-viewer.wxs.in" target="_blank">virt-viewer.wxs.in</a> | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/<a href="http://virt-viewer.wxs.in" target="_blank">virt-viewer.wxs.in</a> b/data/<a href="http://virt-viewer.wxs.in" target="_blank">virt-viewer.wxs.in</a> index 438f341..d5c2522 100644 --- a/data/<a href="http://virt-viewer.wxs.in" target="_blank">virt-viewer.wxs.in</a> +++ b/data/<a href="http://virt-viewer.wxs.in" target="_blank">virt-viewer.wxs.in</a> @@ -125,7 +125,7 @@ </Feature> <InstallExecuteSequence> - <RemoveExistingProducts After="InstallValidate"/> + <RemoveExistingProducts After="InstallFinalize"/> </InstallExecuteSequence> <Icon Id="virt-viewer.ico" SourceFile="../icons/virt-viewer.ico"/> -- 1.8.3.1 </blockquote></div> -- Marc-André Lureau </div>