<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Aug 12, 2014 at 6:10 PM, Jonathon Jongsma <span dir="ltr"><<a href="mailto:jjongsma@redhat.com" target="_blank">jjongsma@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">When collect_credentials() returns a failure status, 'username' was<br>
potentially leaked.<br>
---<br>
src/remote-viewer.c | 11 +++++------<br>
1 file changed, 5 insertions(+), 6 deletions(-)<br>
<br>
Fixed leak mentioned by Christophe<br>
<br>
diff --git a/src/remote-viewer.c b/src/remote-viewer.c<br>
index 30f8444..1f2fa0d 100644<br>
--- a/src/remote-viewer.c<br>
+++ b/src/remote-viewer.c<br>
@@ -717,17 +717,16 @@ authenticate_cb(RestProxy *proxy, G_GNUC_UNUSED RestProxyAuth *auth,<br>
"oVirt",<br>
NULL,<br>
&username, &password);<br>
- if (ret < 0) {<br>
- return FALSE;<br>
- } else {<br>
+ if (ret == 0) {<br>
g_object_set(G_OBJECT(proxy),<br>
"username", username,<br>
"password", password,<br>
NULL);<br>
- g_free(username);<br>
- g_free(password);<br>
- return TRUE;<br>
}<br>
+<br>
+ g_free(username);<br>
+ g_free(password);<br>
+ return (ret == 0);<br>
}<br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
--<br>
1.9.3<br>
<br>
_______________________________________________<br>
virt-tools-list mailing list<br>
<a href="mailto:virt-tools-list@redhat.com">virt-tools-list@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/virt-tools-list" target="_blank">https://www.redhat.com/mailman/listinfo/virt-tools-list</a><br>
</font></span></blockquote></div><br><br clear="all"><div>ACK!</div>-- <br><div>Fabiano Fidêncio</div>
</div></div>