<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 6, 2014 at 9:19 PM, Jonathon Jongsma <span dir="ltr"><<a href="mailto:jjongsma@redhat.com" target="_blank">jjongsma@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im HOEnZb adL">+        if (error) {<br>
+            g_warning("Unable <span class="il">to</span> get <span class="il">comment</span> from key <span class="il">file</span>: %s", error->message);<br></div></blockquote><div><br><br></div><div>I get this warning, while I think this is a normal condition. Shouldn't it be a g_debug instead?<br>
 <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im HOEnZb adL">
+            g_clear_error(&error);<br>
+        } else {<br>
+            if (!<span class="il">comment</span> || *<span class="il">comment</span> == '\0')<br>
+                g_key_file_set_comment(priv-><span class="il">config</span>, priv->uuid, NULL, priv->guest_name, NULL);<br>
+        }</div></blockquote></div><br></div><div class="gmail_extra">So is this patch supposed to add a comment if it doesn't exist? How is it supposed to look like? It would have been nice to add a comment in commit log or in man page if it's supposed to be edited by user?<br>
<br></div><div class="gmail_extra"><br clear="all"><br>-- <br>Marc-André Lureau
</div></div>