<html><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><META name="Author" content="Novell GroupWise WebAccess"><style type="text/css">
body p
{
margin: 0px;
}
</style></head><body style='font-family: Helvetica, Arial, sans-serif; font-size: 13px; '><div id="GroupWiseSection_1410419992000_lma@suse.com_B118D7016C3D0000BC7D000BCD69755F_" class="GroupWiseMessageBody"><div>>>> Cole Robinson <crobinso@redhat.com> 09/06/14 6:28 AM >>><br></div><span class="GroupwiseReplyHeader"></span>......<lma@suse.com><crobinso@redhat.com><br>> - The comparison function will have two consumers: details.py and<br></crobinso@redhat.com></lma@suse.com><lma@suse.com><crobinso@redhat.com>> addhardware.py. But if you lump it in with the 'iterate over all VMs'<br></crobinso@redhat.com></lma@suse.com><lma@suse.com><crobinso@redhat.com>> behavior, it's only useful in addhardware.py.<br>So, I should<br>1. move the comparison logic from details.py:lookup_nodedev to<br>nodedev.py:NodeDevice.compare_to_nodedev, separate the logic <br>implement in PCIDevice and USBDevice.<br>2. in </crobinso@redhat.com></lma@suse.com><lma@suse.com><crobinso@redhat.com>details.py:lookup_nodedev, iterate all of nodedevices & call <br>NodeDevice.compare_to_nodedev to compare against the passed<br>hostdev and the passed nodedev.<br>3. in addhardware.py:validate_page_hostdev, iterate all of hostdevs in<br>all of vms & call </crobinso@redhat.com></lma@suse.com><lma@suse.com><crobinso@redhat.com>NodeDevice.compare_to_nodedev to compare against<br>the passed hostdev and the passed nodedev.<br>Are these right?<br><br>Thanks,<br>Lin<br></crobinso@redhat.com></lma@suse.com></div></body></html>