<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 23, 2014 at 5:34 PM, Fabiano Fidêncio <span dir="ltr"><<a href="mailto:fidencio@redhat.com" target="_blank">fidencio@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">virt_viewer_auth_collect_credentials() was recently changed to return<br>
a boolean instead of an integer (2561c171). This change introduced a<br>
regression in the authentication dialog behavior, do not letting the<br>
user cancel it.<br>
---<br>
src/virt-viewer-session-spice.c | 6 +++---<br>
1 file changed, 3 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/src/virt-viewer-session-spice.c b/src/virt-viewer-session-spice.c<br>
index 2323832..dd96fdf 100644<br>
--- a/src/virt-viewer-session-spice.c<br>
+++ b/src/virt-viewer-session-spice.c<br>
@@ -482,7 +482,7 @@ virt_viewer_session_spice_main_channel_event(SpiceChannel *channel G_GNUC_UNUSED<br>
{<br>
VirtViewerSessionSpice *self = VIRT_VIEWER_SESSION_SPICE(session);<br>
gchar *password = NULL, *user = NULL;<br>
- int ret;<br>
+ gboolean ret;<br>
<br>
g_return_if_fail(self != NULL);<br>
<br>
@@ -513,7 +513,7 @@ virt_viewer_session_spice_main_channel_event(SpiceChannel *channel G_GNUC_UNUSED<br>
"SPICE",<br>
NULL,<br>
NULL, &password);<br>
- if (ret < 0) {<br>
+ if (!ret) {<br>
g_signal_emit_by_name(session, "session-cancelled");<br>
} else {<br>
gboolean openfd;<br>
@@ -542,7 +542,7 @@ virt_viewer_session_spice_main_channel_event(SpiceChannel *channel G_GNUC_UNUSED<br>
ret = virt_viewer_auth_collect_credentials(self->priv->main_window,<br>
"proxy", NULL,<br>
&user, &password);<br>
- if (ret < 0) {<br>
+ if (!ret) {<br>
g_signal_emit_by_name(session, "session-cancelled");<br>
} else {<br>
spice_uri_set_user(proxy, user);<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.9.3<br>
<br>
_______________________________________________<br>
virt-tools-list mailing list<br>
<a href="mailto:virt-tools-list@redhat.com">virt-tools-list@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/virt-tools-list" target="_blank">https://www.redhat.com/mailman/listinfo/virt-tools-list</a><br>
</font></span></blockquote></div><br>self NACK!</div><div class="gmail_extra">Typos in the commit message/short log.</div><div class="gmail_extra"><br>-- <br><div>Fabiano Fidêncio</div>
</div></div>