<div dir="ltr">Hi<br><div class="gmail_extra"><div class="gmail_quote">On Thu, Jun 23, 2016 at 6:45 PM, Fabiano Fidêncio <span dir="ltr"><<a href="mailto:fabiano@fidencio.org" target="_blank">fabiano@fidencio.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Thu, Jun 23, 2016 at 4:53 PM, Lukáš Venhoda <<a href="mailto:lvenhoda@redhat.com">lvenhoda@redhat.com</a>> wrote:<br>
> Adds metadata to be used with Gnome Software.<br>
> Includes name, summary, description and three screenshots of remote-viewer.<br>
> Adds the new file to PO files, and adds instalation of appdata file.<br>
<br>
</span>I'd remove this last line from the commit message.<br>
<span class=""><br></span></blockquote><div><br></div><div>Ok</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
> ---<br>
> data/Makefile.am | 9 +++++++--<br>
> data/<a href="http://remote-viewer.appdata.xml.in" rel="noreferrer" target="_blank">remote-viewer.appdata.xml.in</a> | 28 ++++++++++++++++++++++++++++<br>
> po/POTFILES.in | 1 +<br>
> <a href="http://virt-viewer.spec.in" rel="noreferrer" target="_blank">virt-viewer.spec.in</a> | 1 +<br>
> 4 files changed, 37 insertions(+), 2 deletions(-)<br>
> create mode 100644 data/<a href="http://remote-viewer.appdata.xml.in" rel="noreferrer" target="_blank">remote-viewer.appdata.xml.in</a><br>
><br>
> diff --git a/data/Makefile.am b/data/Makefile.am<br>
> index 821c171..55718d9 100644<br>
> --- a/data/Makefile.am<br>
> +++ b/data/Makefile.am<br>
> @@ -76,6 +76,11 @@ mimedir = $(datadir)/mime/packages<br>
> mime_DATA = virt-viewer-mime.xml<br>
> @INTLTOOL_XML_RULE@<br>
><br>
> +appdatadir = $(datadir)/appdata<br>
> +APPDATAFILES = <a href="http://remote-viewer.appdata.xml.in" rel="noreferrer" target="_blank">remote-viewer.appdata.xml.in</a><br>
<br>
</span>I'm thinking whether we should provide a <a href="http://virt-viewer.appdata.xml.in" rel="noreferrer" target="_blank">virt-viewer.appdata.xml.in</a> as well.<br>
What do you think, Lukaš?<br>
<div><div class="h5"><br></div></div></blockquote><div><br></div><div>Well I think there should be only remote-viewer.appdata.xml, because we only provide only one package.</div><div>Yes. the package name is virt-viewer, but with the Provides fix from last patch this wouldn't be issue.</div><div><br></div><div>If we want to install virt-viewer and remote-viewer from Gnome Software separatly, then yes it would be better to have both,</div><div>but does it make sense to have both if they install the same package?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">
> +appdata_DATA = $(APPDATAFILES:.<a href="http://xml.in" rel="noreferrer" target="_blank">xml.in</a>=.xml)<br>
> +@INTLTOOL_XML_RULE@<br>
> +<br>
> install-data-hook:<br>
> if ENABLE_UPDATE_MIMEDB<br>
> @if $(AM_V_P); then set -x; else echo " INSTALL update-mime-database"; fi; \<br>
> @@ -88,8 +93,8 @@ if ENABLE_UPDATE_MIMEDB<br>
> $(UPDATE_MIME_DATABASE) "$(DESTDIR)$(datadir)/mime";<br>
> endif<br>
><br>
> -CLEANFILES += $(mime_DATA) $(desktop_DATA)<br>
> -EXTRA_DIST += $(MIMEFILES) $(DESKTOPFILES)<br>
> +CLEANFILES += $(mime_DATA) $(desktop_DATA) $(appdata_DATA)<br>
> +EXTRA_DIST += $(MIMEFILES) $(DESKTOPFILES) $(APPDATAFILES)<br>
><br>
> endif<br>
><br>
> diff --git a/data/<a href="http://remote-viewer.appdata.xml.in" rel="noreferrer" target="_blank">remote-viewer.appdata.xml.in</a> b/data/<a href="http://remote-viewer.appdata.xml.in" rel="noreferrer" target="_blank">remote-viewer.appdata.xml.in</a><br>
> new file mode 100644<br>
> index 0000000..5aa2ff3<br>
> --- /dev/null<br>
> +++ b/data/<a href="http://remote-viewer.appdata.xml.in" rel="noreferrer" target="_blank">remote-viewer.appdata.xml.in</a><br>
> @@ -0,0 +1,28 @@<br>
> +<?xml version="1.0" encoding="UTF-8"?><br>
> +<application><br>
> + <id type="desktop">remote-viewer.desktop</id><br>
> + <metadata_license>CC0-1.0</metadata_license><br>
> + <project_license>GPL-2.0+</project_license><br>
> + <_name>Remote Viewer</_name><br>
> + <_summary>Remotely access virtual machines</_summary><br>
> + <description><br>
> + <_p><br>
> + Remote Viewer provides a graphical viewer for the guest OS<br>
> + display. At this time is supports guest OS using the VNC<br>
<br>
</div></div>"(...) At this time it supports (...)" (replace is -> it).<br>
<span class=""><br>
> + or SPICE protocols. Further protocols may be supported in<br>
> + the future as user demand dictates. The viewer can connect<br>
> + directly to both local and remotely hosted guest OS, optionally<br>
> + using SSL/TLS encryption.<br>
<br>
</span>Out of curiosity, where this description comes from?<br>
<span class=""><br></span></blockquote><div><br></div><div>The virt-viewer README. The typo is also there.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
> + </_p><br>
> + </description><br>
> + <screenshots><br>
> + <screenshot type="default"><a href="http://www.spice-space.org/static/images/remote_viewer_youtube.png" rel="noreferrer" target="_blank" title="" style="">http://www.spice-space.org/static/images/remote_viewer_youtube.png</a></screenshot><br>
> + <screenshot><a href="http://www.spice-space.org/static/images/remote_viewer_usbredir.png" rel="noreferrer" target="_blank" title="" style="">http://www.spice-space.org/static/images/remote_viewer_usbredir.png</a></screenshot><br>
> + <screenshot><a href="http://www.spice-space.org/static/images/remote_viewer_shared_folder.png" rel="noreferrer" target="_blank" title="" style="">http://www.spice-space.org/static/images/remote_viewer_shared_folder.png</a></screenshot><br>
> + </screenshots><br>
> + <provides><br>
> + <binary>virt-viewer</binary><br>
> + </provides><br>
> + <url type="homepage"><a href="http://www.spice-space.org/" rel="noreferrer" target="_blank">http://www.spice-space.org/</a></url><br>
<br>
</span>The homepage for virt-viewer is: <a href="https://virt-manager.org/" rel="noreferrer" target="_blank">https://virt-manager.org/</a> and not<br>
<a href="http://www.spice-space.org" rel="noreferrer" target="_blank">http://www.spice-space.org</a><br>
<div><div class="h5"><br></div></div></blockquote><div><br></div><div>Ok will fix</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">
> + <updatecontact><a href="http://virt-tools-list_at_redhat.com" rel="noreferrer" target="_blank">virt-tools-list_at_redhat.com</a></updatecontact><br>
> +</application><br>
> diff --git a/po/POTFILES.in b/po/POTFILES.in<br>
> index b25306d..6775f53 100644<br>
> --- a/po/POTFILES.in<br>
> +++ b/po/POTFILES.in<br>
> @@ -1,3 +1,4 @@<br>
> +data/<a href="http://remote-viewer.appdata.xml.in" rel="noreferrer" target="_blank">remote-viewer.appdata.xml.in</a><br>
> data/<a href="http://remote-viewer.desktop.in" rel="noreferrer" target="_blank">remote-viewer.desktop.in</a><br>
> data/<a href="http://virt-viewer-mime.xml.in" rel="noreferrer" target="_blank">virt-viewer-mime.xml.in</a><br>
> src/remote-viewer-main.c<br>
> diff --git a/<a href="http://virt-viewer.spec.in" rel="noreferrer" target="_blank">virt-viewer.spec.in</a> b/<a href="http://virt-viewer.spec.in" rel="noreferrer" target="_blank">virt-viewer.spec.in</a><br>
> index ed0b14d..4fb649c 100644<br>
> --- a/<a href="http://virt-viewer.spec.in" rel="noreferrer" target="_blank">virt-viewer.spec.in</a><br>
> +++ b/<a href="http://virt-viewer.spec.in" rel="noreferrer" target="_blank">virt-viewer.spec.in</a><br>
> @@ -127,6 +127,7 @@ fi<br>
> %{_datadir}/icons/hicolor/*/apps/*<br>
> %{_datadir}/icons/hicolor/*/devices/*<br>
> %{_datadir}/applications/remote-viewer.desktop<br>
> +%{_datadir}/appdata/remote-viewer.appdata.xml<br>
> %{_datadir}/mime/packages/virt-viewer-mime.xml<br>
> %ghost %{_libexecdir}/spice-xpi-client<br>
> %{_libexecdir}/spice-xpi-client-remote-viewer<br>
> --<br>
> 2.5.5<br>
><br>
</div></div>> _______________________________________________<br>
> virt-tools-list mailing list<br>
> <a href="mailto:virt-tools-list@redhat.com">virt-tools-list@redhat.com</a><br>
> <a href="https://www.redhat.com/mailman/listinfo/virt-tools-list" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/virt-tools-list</a><br>
<br>
<br>
Reviewed-by: Fabiano Fidêncio <<a href="mailto:fidencio@redhat.com">fidencio@redhat.com</a>><br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Fabiano Fidêncio<br>
</font></span></blockquote></div><br clear="all"><div>Thanks</div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Lukas Venhoda</div>
</div></div>