<div dir="ltr">Hi Cole<br><div><br><div class="gmail_quote"><div dir="ltr">On Sun, May 8, 2016 at 3:36 AM Cole Robinson <<a href="mailto:crobinso@redhat.com">crobinso@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 04/28/2016 08:22 AM, Marc-André Lureau wrote:<br class="gmail_msg">
> Signed-off-by: Marc-André Lureau <<a href="mailto:marcandre.lureau@redhat.com" class="gmail_msg" target="_blank">marcandre.lureau@redhat.com</a>><br class="gmail_msg">
> ---<br class="gmail_msg">
>  virtinst/guest.py   | 5 +++++<br class="gmail_msg">
>  virtinst/support.py | 1 +<br class="gmail_msg">
>  2 files changed, 6 insertions(+)<br class="gmail_msg">
><br class="gmail_msg">
> diff --git a/virtinst/guest.py b/virtinst/guest.py<br class="gmail_msg">
> index ab6dcba..5824e87 100644<br class="gmail_msg">
> --- a/virtinst/guest.py<br class="gmail_msg">
> +++ b/virtinst/guest.py<br class="gmail_msg">
> @@ -1141,6 +1141,11 @@ class Guest(XMLBuilder):<br class="gmail_msg">
>                  if dev.image_compression is None:<br class="gmail_msg">
>                      dev.image_compression = "off"<br class="gmail_msg">
><br class="gmail_msg">
> +            if (dev.type == "spice" and<br class="gmail_msg">
> +                 not self.conn.check_support(<br class="gmail_msg">
> +                     self.conn.SUPPORT_CONN_SPICE_GL)):<br class="gmail_msg">
> +                 raise ValueError(_("Host does not support spice GL"))<br class="gmail_msg">
> +<br class="gmail_msg">
>      def _add_spice_channels(self):<br class="gmail_msg">
>          if self.skip_default_channel:<br class="gmail_msg">
>              return<br class="gmail_msg">
> diff --git a/virtinst/support.py b/virtinst/support.py<br class="gmail_msg">
> index 1071750..1925986 100644<br class="gmail_msg">
> --- a/virtinst/support.py<br class="gmail_msg">
> +++ b/virtinst/support.py<br class="gmail_msg">
> @@ -311,6 +311,7 @@ SUPPORT_CONN_VCPU_PLACEMENT = _make(<br class="gmail_msg">
>  SUPPORT_CONN_MEM_STATS_PERIOD = _make(<br class="gmail_msg">
>      function="virDomain.setMemoryStatsPeriod",<br class="gmail_msg">
>      version="1.1.1", hv_version={"qemu": 0})<br class="gmail_msg">
> +SUPPORT_CONN_SPICE_GL = _make(version="1.3.3", hv_version={"qemu": "2.5.92"})<br class="gmail_msg">
><br class="gmail_msg">
<br class="gmail_msg">
If we are going to wait for the libvirt listen type=none, maybe we can avoid<br class="gmail_msg">
this and use libvirt domcapabilities instead. It's on my todo list to use<br class="gmail_msg">
domcapabilities to advertise spice gl bits. We will see how this libvirt<br class="gmail_msg">
release cycle goes<br class="gmail_msg"></blockquote><div><br></div><div>Any news regarding domcapabilities? Should we go with that patch instead for now?<br> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="gmail_msg">
Thanks,<br class="gmail_msg">
Cole<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
virt-tools-list mailing list<br class="gmail_msg">
<a href="mailto:virt-tools-list@redhat.com" class="gmail_msg" target="_blank">virt-tools-list@redhat.com</a><br class="gmail_msg">
<a href="https://www.redhat.com/mailman/listinfo/virt-tools-list" rel="noreferrer" class="gmail_msg" target="_blank">https://www.redhat.com/mailman/listinfo/virt-tools-list</a></blockquote></div></div></div><div dir="ltr">-- <br></div><div data-smartmail="gmail_signature"><div dir="ltr">Marc-André Lureau<br></div></div>