<div dir="ltr">Hi,<br><div><div class="gmail_extra"><br><div class="gmail_quote">2017-08-04 23:53 GMT+02:00 Eduardo Lima (Etrunko) <span dir="ltr"><<a href="mailto:etrunko@redhat.com" target="_blank">etrunko@redhat.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">This can save us some bandwidth, as we are searching for the specific<br>
virtual machine instead of retrieving the collection with all VMs, and<br>
then iterating over the results after the transfer finishes.<br>
<br>
Signed-off-by: Eduardo Lima (Etrunko) <<a href="mailto:etrunko@redhat.com" target="_blank">etrunko@redhat.com</a>><br>
---<br>
src/ovirt-foreign-menu.c | 6 +++++-<br>
1 file changed, 5 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c<br>
index fdfd327..539f716 100644<br>
--- a/src/ovirt-foreign-menu.c<br>
+++ b/src/ovirt-foreign-menu.c<br>
@@ -696,12 +696,16 @@ static void ovirt_foreign_menu_fetch_vm_as<wbr>ync(OvirtForeignMenu *menu,<br>
GTask *task)<br>
{<br>
OvirtCollection *vms;<br>
+ char *query;<br></blockquote><div>g_strdup_printf returns gchar *<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
g_return_if_fail(OVIRT_IS_FOR<wbr>EIGN_MENU(menu));<br>
g_return_if_fail(OVIRT_IS_PRO<wbr>XY(menu->priv->proxy));<br>
g_return_if_fail(OVIRT_IS_<wbr>API(menu->priv->api));<br>
<br>
- vms = ovirt_api_get_vms(menu->priv-><wbr>api);<br>
+ query = g_strdup_printf("id=%s", menu->priv->vm_guid);<br>
+ vms = ovirt_api_search_vms(menu->pri<wbr>v->api, query);<br></blockquote><div>it looks like api from unreleased version of libgovirt, remote-viewer depends on libgovirt 0.3.2<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+ g_free(query);<br>
+<br>
ovirt_collection_fetch_async(<wbr>vms, menu->priv->proxy,<br>
g_task_get_cancellable(task),<br>
vms_fetched_cb, task);<br></blockquote><div><br></div><div>You can go for AC_CHECK_FUNCS and do it conditionally based on the function presence to keep it builldable on distros not shipping the very recent libgovirt<br><br></div><div>IMHO would be better to have a release of libgovirt to make the new api stable :) (However I'd still consider using the `#ifdef <code>HAVE_OVIRT_API_SEARCH_VMS` check)<br><br></code></div><div><code>Cheers!<br></code></div><div><code>Pavel<br></code></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span class="gmail-m_7118144935306976298gmail-HOEnZb"><font color="#888888">--<br>
2.13.4<br>
<br>
______________________________<wbr>_________________<br>
virt-tools-list mailing list<br>
<a href="mailto:virt-tools-list@redhat.com" target="_blank">virt-tools-list@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/virt-tools-list" rel="noreferrer" target="_blank">https://www.redhat.com/mailman<wbr>/listinfo/virt-tools-list</a><br>
</font></span></blockquote></div><br></div></div></div>