<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body text="#000000" bgcolor="#FFFFFF"> Hi Anthony, This is an example of git send-email command to send the last 4 commits to <a class="moz-txt-link-abbreviated" href="mailto:virt-tools-list@redhat.com">virt-tools-list@redhat.com</a> git send-email -4 --to <a class="moz-txt-link-abbreviated" href="mailto:virt-tools-list@redhat.com">virt-tools-list@redhat.com</a> --subject-prefix="virt-manager] [PATCH" --annotate --cover-letter For more information see: <a class="moz-txt-link-freetext" href="https://git-scm.com/docs/git-send-email">https://git-scm.com/docs/git-send-email</a> Kind Regards, Radostin <div class="moz-cite-prefix">On 20/12/17 19:05, Anthony Serna wrote: </div> <blockquote type="cite" cite="mid:CAF8fV66yRhK5jJYXb=2CB=oxF+7tEe2vcZsWzdrPcCsCfFHoOw@mail.gmail.com"> <div> <div dir="auto">Thank you. I couldn't get git send-email to work.</div> <div class="gmail_quote"> <div>On Wed, Dec 20, 2017 at 11:03 AM Cole Robinson <<a href="mailto:crobinso@redhat.com" moz-do-not-send="true">crobinso@redhat.com</a>> wrote: </div> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 12/13/2017 10:24 AM, Michal Privoznik wrote: > On 12/11/2017 07:00 PM, Anthony Serna wrote: >> Patch attached. >> >> Just a small thing I noticed when spinning up an LXC container. > > Hey, > > welcome to the list. Just a couple of hints for your patch: > >> >> >> 0001-strings-fix-typo.patch > > a) We usually send patches directly, not as attachments. You can achieve > this by executing: git send-email ... >> >> >> From 23fdcdbb1c5ee89addc0ef5d745453eaa6b0b235 Mon Sep 17 00:00:00 2001 >> From: Anthony <<a href="mailto:aserna3@gmail.com" target="_blank" moz-do-not-send="true">aserna3@gmail.com</a>> >> Date: Mon, 11 Dec 2017 09:56:13 -0800 >> Subject: [PATCH] strings: fix typo >> >> --- >> po/as.po | 2 +- >> po/bg.po | 2 +- >> po/bn_IN.po | 2 +- >> po/bs.po | 2 +- >> po/ca.po | 2 +- >> po/cmn.po | 2 +- >> po/cs.po | 2 +- >> po/da.po | 2 +- >> po/de.po | 2 +- >> po/en_GB.po | 2 +- >> po/es.po | 2 +- >> po/fi.po | 2 +- >> po/fr.po | 2 +- >> po/gu.po | 2 +- >> po/hi.po | 2 +- >> po/hr.po | 2 +- >> po/hu.po | 2 +- >> po/is.po | 2 +- >> po/it.po | 2 +- >> po/ja.po | 2 +- >> po/kn.po | 2 +- >> po/ko.po | 2 +- >> po/ml.po | 2 +- >> po/mr.po | 2 +- >> po/ms.po | 2 +- >> po/nb.po | 2 +- >> po/nl.po | 2 +- >> po/or.po | 2 +- >> po/pa.po | 2 +- >> po/pl.po | 4 ++-- >> po/pt.po | 2 +- >> po/pt_BR.po | 2 +- >> po/ro.po | 2 +- >> po/ru.po | 2 +- >> po/sk.po | 2 +- >> po/sr.po | 2 +- >> <a class="moz-txt-link-abbreviated" href="mailto:po/sr@latin.po">po/sr@latin.po</a> | 2 +- >> po/sv.po | 2 +- >> po/ta.po | 2 +- >> po/te.po | 2 +- >> po/tr.po | 2 +- >> po/uk.po | 4 ++-- >> po/vi.po | 2 +- >> po/zh_CN.po | 2 +- >> po/zh_TW.po | 2 +- >> 45 files changed, 47 insertions(+), 47 deletions(-) > > b) these files are generated (despite being tracked in the repo). You > need to fix the root of the bug (which is in ui/create.ui. These po/ > files will be updated then just before the release. > I agree with Michal's comments, but I fixed the patch for you to just apply to ui/create.ui and pushed Thanks, Cole </blockquote> </div> </div> <fieldset class="mimeAttachmentHeader"></fieldset> <pre wrap="">_______________________________________________ virt-tools-list mailing list <a class="moz-txt-link-abbreviated" href="mailto:virt-tools-list@redhat.com">virt-tools-list@redhat.com</a> <a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/virt-tools-list">https://www.redhat.com/mailman/listinfo/virt-tools-list</a></pre> </blockquote> </body> </html>