<div dir="ltr"><div><div>Thanks, both - I've been after that functionality for quite some time, but have never quite got far enough into Python to add it myself.  I look forward to making use of your hard work!<br><br></div>Cheers,<br><br></div>- Peter<br></div><div class="gmail_extra"><br><div class="gmail_quote">On 30 January 2018 at 16:34, Cole Robinson <span dir="ltr"><<a href="mailto:crobinso@redhat.com" target="_blank">crobinso@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On 01/29/2018 01:37 AM, Rauno Väli wrote:<br>
> libvirt pool dumpxml:<br>
> <pool type='rbd'><br>
>   <name>rbd.test</name><br>
>   <uuid>57e55e10-63c9-4166-861c-<wbr>f330d868260c</uuid><br>
>   <capacity unit='bytes'>36792725520384</<wbr>capacity><br>
>   <allocation unit='bytes'>760411510361</<wbr>allocation><br>
>   <available unit='bytes'>34510461812736</<wbr>available><br>
>   <source><br>
>     <host name='10.10.40.1' port='6789'/><br>
>     <host name='10.10.40.2' port='6789'/><br>
>     <host name='10.10.40.3' port='6789'/><br>
>     <name>rbd.test</name><br>
>     <auth type='ceph' username='admin'><br>
>       <secret uuid='f65cc5a8-b77b-4254-9030-<wbr>d50a528fb456'/><br>
>     </auth><br>
>   </source><br>
> </pool><br>
><br>
> with this patch i get correct disk definition using virt-install:<br>
> ...<br>
>     <disk type='network' device='disk'><br>
>       <driver name='qemu' type='raw' cache='writeback'/><br>
>       <auth username='admin'><br>
>         <secret type='ceph' uuid='f65cc5a8-b77b-4254-9030-<wbr>d50a528fb456'/><br>
>       </auth><br>
>       <source protocol='rbd'<br>
> name='rbd.test/50845b54-0ed6-<wbr>48e9-8d84-07b2cd2c0c4d.img'><br>
>         <host name='10.10.40.1' port='6789'/><br>
>         <host name='10.10.40.2' port='6789'/><br>
>         <host name='10.10.40.3' port='6789'/><br>
>       </source><br>
>       <target dev='vda' bus='virtio'/><br>
>       <alias name='virtio-disk0'/><br>
>       <address type='pci' domain='0x0000' bus='0x00' slot='0x07'<br>
> function='0x0'/><br>
>     </disk><br>
> ...<br>
><br>
> Without the patch it took only one host entry and no auth element. so<br>
> the domain would fail.<br>
><br>
<br>
</div></div>Thanks! I stuffed in some test coverage, fixed some pylint warnings,<br>
tweaked the commit message, and pushed your patch now.<br>
<div class="HOEnZb"><div class="h5"><br>
Thanks,<br>
Cole<br>
<br>
______________________________<wbr>_________________<br>
virt-tools-list mailing list<br>
<a href="mailto:virt-tools-list@redhat.com">virt-tools-list@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/virt-tools-list" rel="noreferrer" target="_blank">https://www.redhat.com/<wbr>mailman/listinfo/virt-tools-<wbr>list</a></div></div></blockquote></div><br></div>