<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, May 20, 2021 at 6:28 AM Cole Robinson <<a href="mailto:crobinso@redhat.com">crobinso@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 5/18/21 2:36 AM, Han Han wrote:<br>
> Support rotation_rate attrib which is introduced since libvirt v7.3.<br>
> <br>
> Signed-off-by: Han Han <<a href="mailto:hhan@redhat.com" target="_blank">hhan@redhat.com</a>><br>
<br>
Thanks! But you need to extend tests/test_cli.py --disk examples as well<br>
otherwise test suite is failing (but I didn't confirm)<br></blockquote><div>OK. I will have a try in v2 <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Thanks,<br>
Cole<br>
<br>
> ---<br>
>  virtinst/cli.py          | 2 ++<br>
>  virtinst/devices/disk.py | 1 +<br>
>  2 files changed, 3 insertions(+)<br>
> <br>
> diff --git a/virtinst/cli.py b/virtinst/cli.py<br>
> index 4ce3abf9..e4676bc9 100644<br>
> --- a/virtinst/cli.py<br>
> +++ b/virtinst/cli.py<br>
> @@ -3252,6 +3252,7 @@ class ParserDisk(VirtCLIParser):<br>
>          "snapshot": "snapshot_policy",<br>
>          "<a href="http://target.dev" rel="noreferrer" target="_blank">target.dev</a>": "target",<br>
>          "target.removable": "removable",<br>
> +        "target.rotation_rate": "rotation_rate",<br>
>  <br>
>          "driver.discard": "discard",<br>
>          "driver.detect_zeroes": "detect_zeroes",<br>
> @@ -3443,6 +3444,7 @@ class ParserDisk(VirtCLIParser):<br>
>          cls.add_arg("target.bus", "bus")<br>
>          cls.add_arg("target.removable", "removable", is_onoff=True)<br>
>          cls.add_arg("<a href="http://target.dev" rel="noreferrer" target="_blank">target.dev</a>", "target")<br>
> +        cls.add_arg("target.rotation_rate", "rotation_rate")<br>
>  <br>
>          cls.add_arg("driver.cache", "driver_cache")<br>
>          cls.add_arg("driver.discard", "driver_discard")<br>
> diff --git a/virtinst/devices/disk.py b/virtinst/devices/disk.py<br>
> index a8971581..77f10340 100644<br>
> --- a/virtinst/devices/disk.py<br>
> +++ b/virtinst/devices/disk.py<br>
> @@ -471,6 +471,7 @@ class DeviceDisk(Device):<br>
>      bus = XMLProperty("./target/@bus")<br>
>      target = XMLProperty("./target/@dev")<br>
>      removable = XMLProperty("./target/@removable", is_onoff=True)<br>
> +    rotation_rate = XMLProperty("./target/@rotation_rate", is_int=True)<br>
>  <br>
>      read_only = XMLProperty("./readonly", is_bool=True)<br>
>      shareable = XMLProperty("./shareable", is_bool=True)<br>
> <br>
<br>
<br>
- Cole<br>
<br>
</blockquote></div></div>