<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta http-equiv="Content-Type" content="text/xhtml; charset=utf-8"> </head> <body> <div style="font-family:sans-serif"><div style="white-space:normal"> <p dir="auto">On 25 Sep 2016, at 15:41, Baiju Muthukadan wrote:</p> <p dir="auto"></p></div> <div style="white-space:pre-wrap"><blockquote style="border-left:2px solid #777; color:#777; margin:0 0 5px; padding-left:5px"><div dir="auto">Hi Max, </div><div dir="auto"> </div><div dir="auto">On Sun, Sep 25, 2016 at 4:44 PM, Max Andersen <manderse@redhat.com> wrote: </div><blockquote style="border-left:2px solid #777; color:#999; margin:0 0 5px; padding-left:5px; border-left-color:#999"><div dir="auto">Why fork ? Is it not enough to just not use the Cassandra parts ? </div><div dir="auto"> </div><div dir="auto">Also, wasn't a similar library found and it was rejected since it only </div><div dir="auto">allowed .sql migrations where we wanted go based migrations too ? </div></blockquote><div dir="auto"> </div><div dir="auto">As per earlier discussion, there were three reasons for not choosing </div><div dir="auto">the other project: </div><div dir="auto"><a href="https://github.com/almighty/almighty-core/issues/184#issuecomment-246901574" style="color:#777">https://github.com/almighty/almighty-core/issues/184#issuecomment-246901574</a> </div><div dir="auto"> </div><blockquote style="border-left:2px solid #777; color:#999; margin:0 0 5px; padding-left:5px; border-left-color:#999"><div dir="auto">1. We only have to support one database (PostgreSQL) and not the many others supported by the project. </div></blockquote><div dir="auto"> </div><div dir="auto">This is one the reason that I forked the project. Because the </div><div dir="auto">original author may not be interested to remove features. </div></blockquote></div> <div style="white-space:normal"> <p dir="auto">But why would it matter ? the cassandra stuff is separate anyway. I don't see how this <em>hurt</em> and justify fork and removing features.</p> <p dir="auto">In the original discussion I read this as the extra support for other databases was not important/reason to choose sql-migrate - not as reasons for not moving to it. </p> <p dir="auto"></p></div> <div style="white-space:pre-wrap"><blockquote style="border-left:2px solid #777; color:#777; margin:0 0 5px; padding-left:5px"><blockquote style="border-left:2px solid #777; color:#999; margin:0 0 5px; padding-left:5px; border-left-color:#999"><div dir="auto">2. We want to have pre- and post-migration scripts (probably in Go) that need to run smart migration steps, that would otherwise be too cumbersome to write in pure SQL files. </div></blockquote><div dir="auto"> </div><div dir="auto">I have implemented this feature. See the documentation: </div><div dir="auto"><a href="https://godoc.org/github.com/baijum/pgmigration" style="color:#777">https://godoc.org/github.com/baijum/pgmigration</a> </div></blockquote></div> <div style="white-space:normal"> <p dir="auto">the doc still says migrations need have an .sql ending and placed in <code style="background-color:#F7F7F7; border-radius:3px; margin:0; padding:0 0.4em" bgcolor="#F7F7F7">db/migrate</code>.</p> <p dir="auto">Thus I'm not grokking where you added support for go based migrations ?</p> <p dir="auto"></p></div> <div style="white-space:pre-wrap"><blockquote style="border-left:2px solid #777; color:#777; margin:0 0 5px; padding-left:5px"><div dir="auto">If the first reason for forking can be ignored, I can send this </div><div dir="auto">feature to the original project and we can use that. Please let me </div><div dir="auto">know. </div></blockquote></div> <div style="white-space:normal"> <p dir="auto">Seem to be useful for upstream project so why not put upstream if we think it is useful ?</p> <p dir="auto">btw. if we want to use a library why then not extend <a href="https://github.com/mattes/migrate" style="color:#3983C4">https://github.com/mattes/migrate</a> that has builtin support for extensions like this ? </p> <p dir="auto">Actually with its bash support Go would be supported (<a href="https://github.com/mattes/migrate/issues/88" style="color:#3983C4">https://github.com/mattes/migrate/issues/88</a>)</p> <p dir="auto">I'm not really expert on go migrations libs but just seems there already are basics in place that can be used - thus either make the simplest thing we can now or use one of the popular ones (i.e. <code style="background-color:#F7F7F7; border-radius:3px; margin:0; padding:0 0.4em" bgcolor="#F7F7F7">migrate</code>)</p> <p dir="auto"></p></div> <div style="white-space:pre-wrap"><blockquote style="border-left:2px solid #777; color:#777; margin:0 0 5px; padding-left:5px"><blockquote style="border-left:2px solid #777; color:#999; margin:0 0 5px; padding-left:5px; border-left-color:#999"><div dir="auto">3. We don't want to support down-migrations. </div></blockquote><div dir="auto"> </div><div dir="auto">The current package doesn't have down-migrations. </div></blockquote></div> <div style="white-space:normal"> <p dir="auto">sure and even if it had we would not use it and thus not affect us.</p> <p dir="auto">/max<br> <a href="http://about.me/maxandersen" style="color:#3983C4">http://about.me/maxandersen</a></p> </div> </div> </body> </html>