<div dir="ltr">Aslak,<div><br></div><div>good point! I've disabled the repos on reviewable and also hard-deleted the webhook from github. Previously I only deactivated it.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 2, 2017 at 1:02 PM, Aslak Knutsen <span dir="ltr"><<a href="mailto:aslak@redhat.com" target="_blank">aslak@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hmm.. interesting...<div><br></div><div>They seem to be using one of the 'repo admins' tokens to re-enable the hook/config. </div><div><br></div><div>I've deleted the access to my account now. Konrad?</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>-aslak-</div></font></span></div><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Mon, Jan 2, 2017 at 9:36 AM, Shoubhik Bose <span dir="ltr"><<a href="mailto:shbose@redhat.com" target="_blank">shbose@redhat.com</a>></span> wrote:<br></span><div><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">"Reviewable" webhook seems to be active yet again in almighty/almighty-core , any clue why it was done? :)<br></div><div class="m_-944414524884063616HOEnZb"><div class="m_-944414524884063616h5"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 19, 2016 at 8:12 PM, Todd Mancini <span dir="ltr"><<a href="mailto:tmancini@redhat.com" target="_blank">tmancini@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Lack of sleep and context did not help here. Ignore me.</div><div class="m_-944414524884063616m_-5472688512729385863HOEnZb"><div class="m_-944414524884063616m_-5472688512729385863h5"><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Sep 18, 2016 at 8:11 PM, Aslak Knutsen <span dir="ltr"><<a href="mailto:aslak@redhat.com" target="_blank">aslak@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Don't listen to Todd, his answering in his sleep... :)<div><br></div><div>The main reason we moved to Reviewable was to keep track of 'unanswered' comments during large reviews. I'm not seeing 100% how the new GitHub review fixes this, but, the new GitHub Review definitely has nicer reviews than before and with generally smaller pull requests I think we should be able to use it with no problem.</div><div><br></div><div>My take would be; Let's try GitHub Review for a while and see if it works for what we need. If not, we can move back to Reviewable later.</div><div><br></div><div>-aslak- </div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="m_-944414524884063616m_-5472688512729385863m_-6238193654621866179h5">On Sun, Sep 18, 2016 at 9:06 PM, Todd Mancini <span dir="ltr"><<a href="mailto:tmancini@redhat.com" target="_blank">tmancini@redhat.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="m_-944414524884063616m_-5472688512729385863m_-6238193654621866179h5"><div><div><div style="font-family:Calibri,sans-serif;font-size:11pt">Yes, we should continue with our implementation. There are many reasons, but the main reason is that, although we are using GitHub today, the future plans do not require GitHub.<br><br>Sent from my phone, so anticipate hilarious autocorrects</div></div><div dir="ltr"><hr><span style="font-family:Calibri,sans-serif;font-size:11pt;font-weight:bold">From: </span><span style="font-family:Calibri,sans-serif;font-size:11pt"><a href="mailto:shbose@redhat.com" target="_blank">Shoubhik Bose</a></span><br><span style="font-family:Calibri,sans-serif;font-size:11pt;font-weight:bold">Sent: </span><span style="font-family:Calibri,sans-serif;font-size:11pt">9/16/2016 2:57 AM</span><br><span style="font-family:Calibri,sans-serif;font-size:11pt;font-weight:bold">To: </span><span style="font-family:Calibri,sans-serif;font-size:11pt"><a href="mailto:almighty-public@redhat.com" target="_blank">ALMighty-public</a></span><br><span style="font-family:Calibri,sans-serif;font-size:11pt;font-weight:bold">Subject: </span><span style="font-family:Calibri,sans-serif;font-size:11pt">[almighty] Code review integration</span><br><br></div></div><div><div><div dir="ltr">Github has added new features for tracking code review , should we be continuing with reviewable ?<br></div>
</div></div><br></div></div>______________________________<wbr>_________________<br>
almighty-public mailing list<br>
<a href="mailto:almighty-public@redhat.com" target="_blank">almighty-public@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/almighty-public" rel="noreferrer" target="_blank">https://www.redhat.com/mailman<wbr>/listinfo/almighty-public</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div><br>______________________________<wbr>_________________<br>
almighty-public mailing list<br>
<a href="mailto:almighty-public@redhat.com" target="_blank">almighty-public@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/almighty-public" rel="noreferrer" target="_blank">https://www.redhat.com/mailman<wbr>/listinfo/almighty-public</a><br>
<br></blockquote></div></div></div><br></div>
<br>______________________________<wbr>_________________<br>
almighty-public mailing list<br>
<a href="mailto:almighty-public@redhat.com">almighty-public@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/almighty-public" rel="noreferrer" target="_blank">https://www.redhat.com/<wbr>mailman/listinfo/almighty-<wbr>public</a><br>
<br></blockquote></div><br></div>