[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[PATCH] move boot param changes to doPostInstall()



Appending kernel boot parameters to the bootloader arguments is very
much a post install thing.  doInstall() should only be performing
rpm-specific installation activities.

(Untested) patch attached.

Cheers,

Matt
Index: packages.py
===================================================================
RCS file: /usr/local/CVS/anaconda/packages.py,v
retrieving revision 1.251
diff -u -r1.251 packages.py
--- packages.py	4 Oct 2004 15:51:42 -0000	1.251
+++ packages.py	11 Oct 2004 20:20:37 -0000
@@ -1055,10 +1055,6 @@
     except Exception, e:
         log("failed to unlink /var/lib/rpm: %s" %(e,))
 
-    if id.grpset.hdrlist.has_key("rhgb") and id.grpset.hdrlist["rhgb"].isSelected():
-        log("rhgb installed, adding to boot loader config")
-        id.bootloader.args.append("rhgb quiet")
-
     instLog.close ()
 
     id.instProgress = None
@@ -1066,6 +1062,11 @@
 def doPostInstall(method, id, intf, instPath):
     if flags.test:
 	return
+
+    if id.grpset.hdrlist.has_key("rhgb") and id.grpset.hdrlist["rhgb"].isSelected():
+        log("rhgb installed, adding to boot loader config")
+        id.bootloader.args.append("rhgb quiet")
+
 
     w = intf.progressWindow(_("Post Install"),
                             _("Performing post install configuration..."), 6)

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]