[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 05/05] add iscsi guy install



On Mon, Feb 06, 2006 at 04:39:09PM -0500, Jeremy Katz wrote:
> On Fri, 2006-02-03 at 14:05 -0800, Patrick Mansfield wrote:
> > Add the iscsi_gui.py install module, and the call to it. 
> 
> Looks fine.
> 
> > Add iscsi glade file.
> 
> This could use a little bit of HIG love.  Main suggestions for

:)

> improvement would be
> * Bold the labels

How do I bold them? Any example usage?  I haven't found any obvious usage in
any glade files.

Do I need something like the pango.WEIGHT_BOLD usage in iw/partition_gui.py?
That one seems to apply to the entered text, not the label.

> * Use a : before the entries
> * The table shouldn't need to be in an alignment
> * Instead of putting the default in braces for the port, just set the
> default port in the entry box 
> * Consistency in capitalization of the labels

OK ...

-- Patrick Mansfield


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]