[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH]Validation of root password with cracklib



On Mon, 2007-12-17 at 12:27 +0900, HARA Hiroshi wrote:
> Matthew Miller wrote:
> > On Mon, Dec 17, 2007 at 11:07:04AM +0900, HARA Hiroshi wrote:
> >>> "Bad password" is too vague. This message needs to explain that the 
> >>> password
> >>> isn't strong enough to meet some basic tests, not just that it's bad.
> >> I see. as you said, only "Bad password" is too vague, but "msg" can explain 
> >> something.
> > 
> > Right. Perhaps starting with "Weak Password" as the caption, and then
> > explaining a bit more.
> Thank you, so I changed the caption from "Bad Password" to
> "Weak Password". (But any other messages are same as passwd command's)

It might be better to also change the text in the message box to be
"Weak password provided" rather than "BAD PASSWORD" both for consistency
and to be a little bit more user-friendly.

Also, instead of importing cracklib in the middle of modules, it should
be imported at the top of the files with the rest of the imports

Jeremy


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]