[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] larger inodes for ext3 at install time



Peter Jones wrote:
Peter Jones wrote:
Eric Sandeen wrote:
Jeremy Katz wrote:
On Tue, 2007-10-23 at 11:40 -0500, Eric Sandeen wrote:
Larger inodes should help out with selinux and/or beagle attributes a bit (xattrs can be stored in-inode) and also makes upgrade to ext4 possible
(which needs an in-inode extent list)
So the obvious question is "if this is so useful, why not have mke2fs do
the right thing without us having to pass more arguments to it"?

Ok, I can do that if you prefer.  Although if you don't plan to migrate
to ext4, and don't use xattrs, you might want the smaller inodes to save
space, since inode overhead on ext$FOO is nontrivial.

I'm not sure where upstream is going on this one, but I can sort it out
if you'd rather not have it in anaconda.

Why not do something like the patches at http://people.redhat.com/pjones/fsprofile/ instead, so next time the ext3 guys come up with a new option, we won't have to explicitly add support for it as well?

Granted, to be truly useful we either need "include" directives in mke2fs.conf or a command line argument to specify a config file. Either (or both) would allow a user to put mke2fs.conf in an updates.img , and so they could define their own options that way.

... something like this will do fine for that part, actually:

Index: fsset.py
===================================================================
RCS file: /usr/local/CVS/anaconda/fsset.py,v
retrieving revision 1.341
diff -u -p -r1.341 fsset.py
--- fsset.py    24 Oct 2007 14:24:14 -0000      1.341
+++ fsset.py    24 Oct 2007 14:28:47 -0000
@@ -2625,7 +2625,18 @@ def ext2FormatFilesystem(argList, messag
         os.dup2(fd, 2)
         os.close(p[1])
         os.close(fd)
-        os.execvp(argList[0], argList)
+
+        env = os.environ
+        configs = [ "/mnt/source/RHupdates/mke2fs.conf",
+                    "/tmp/updates/mke2fs.conf",
+                    "/etc/mke2fs.conf",
+                  ]
+        for config in configs:
+            if os.access(config, os.R_OK):
+                env['MKE2FS_CONF'] = config

This should be:
                   env['MKE2FS_CONFIG'] = config

+                break
+
+        os.execve(argList[0], argList, env)

This should be:

           os.execvpe(argList[0], argList, env)

With these changes the patch works, so I'm going to go ahead and commit it to HEAD.

--
  Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]