[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] rework image handling



In general, doesn't seem like a wrong thing to do, but ....

On Fri, 2007-09-14 at 23:29 -0400, Bill Nottingham wrote:
> The attached:
> 
> 1) cleans up/simplifies readImageFromFile, removing options no longer used

Looks okay.  Need to make sure that the splash image still looks okay
with this at a lower res (like a livecd install running the desktop at
800x600), but I think it should be okay.

> 2) introduces a readIconFromTheme, which pulls icons from the system theme

Sounds good

> 3) uses readIconFromTheme, where available, using XDG standard names

Some of the icons being used are ... a bit arbitrary as "this matches
what the image was" rather than "this is the intent of the icon naming
theme.  eg, using applications-internet for the timezone screen just
happens to work given our icon theme, but can't really be guaranteed at
all.  If there's not something which matches the intent, we probably
shouldn't go with it to avoid more problems down the road.

Jeremy


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]