[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] bugfix- livecd.py support for non-selinux installations



On Fri, 2007-09-14 at 14:49 -0500, Douglas McClendon wrote:
> Jeremy Katz wrote:
> > On Fri, 2007-09-14 at 09:16 -0500, Douglas McClendon wrote:
> >> I tested this patch-against-current-cvs, against an f7 livecd spin, 
> >> under qemu.
> > 
> > Could be a little simpler by just setting the tuple looped over to
> > either include both /selinux and /dev or just /dev based on
> > flags.selinux.  Would also make the diff a bit smaller
> 
> Sure.  It was a means to an end - turboLiveInst-v3 is on its way 
> (pending completion of current qemu test).
> 
> So should I do like you said for the smallest diff, or perhaps go with 
> an initialized-empty list, that selinux gets optionally appended to, and 
> then the list of 'the rest'(==/dev right now) gets appended to that?

Yeah -- but to save you some busy work, I just went ahead and did so
(and moved things into a common method so that we don't have the code
cut and pasted).  

Jeremy


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]