[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: PATCH; make iscsi login code wait for udev to create the devices (#466661, #470073)



> diff --git a/iscsi.py b/iscsi.py
> index a42a03e..915e9ca 100644
> --- a/iscsi.py
> +++ b/iscsi.py
> @@ -189,6 +189,11 @@ class iscsiTarget:
>                  ret = True
>                  self.addNode(node)
>  
> +        # Wait for udev to create the devices for the just added disks
> +        if ret:
> +            iutil.execWithRedirect("/sbin/udevsettle", [ ], 
> +                                   stdout = "/dev/tty5", stderr="/dev/tty5")
> +
>          # we return True if there were any successful logins for our portal.
>          return ret
>  

Only thing I'd note here is that udevsettle can, on occassion, take
several minutes to get around to finishing.  I added a wait window in
turnOnFilesystems that explains what's going on, though most of the time
it'll display only very briefly.  On the rare occassion that udevsettle
takes a very long time, at least anaconda doesn't look hung.  You may
wish to consider that here too.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]