[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

PATCH: Do not stop and restart iscsid when rescanning disks/partitions (#470223)



Hi All,

anaconda kills and restarts iscsid each time an iscsi / zfcp disk gets added,
resulting in messages like these on tty4:

<28> Nov  6 11:30:06 iscsid: connection1:0 is operational now
<28> Nov  6 11:30:07 iscsid: iscsid shutting down.
<28> Nov  6 11:30:08 iscsid: iscsid with pid=1359 started
<28> Nov  6 11:30:09 iscsid: session
[iqn.2005-03.com.max:testdisk,192.168.1.100:3260] already running
<28> Nov  6 11:30:09 iscsid: connection1:0 is operational after recovery (1
attempts)

Esp. the "connection1:0 is operational after recovery (1 attempts)" clearly
indicates that this is not a good thing todo. iscsid is designed as a kernel
helper daemon, which when iscsi is used should be started and never stopped
again.

Note that this means iscsi.startup() also will not get called during the
partitionobjinit step, this is a no-op the first time as then the initiator
name has not been set yet, and if we go back and forth over this step we do not
want to start / stop iscsid, just as we don't want to do that for each iscsi
target added.

Regards,

Hans
>From 708a8bd3cb53b0a3891ebf913a11070c328a62c0 Mon Sep 17 00:00:00 2001
From: Hans de Goede <hdegoede redhat com>
Date: Thu, 6 Nov 2008 17:24:14 +0100
Subject: [PATCH] Do not stop and restart iscsid when rescanning disks/partitions (#470223)

anaconda kills and restarts iscsid each time an iscsi / zfcp disk gets added,
resulting in messages like these on tty4:

<28> Nov  6 11:30:06 iscsid: connection1:0 is operational now
<28> Nov  6 11:30:07 iscsid: iscsid shutting down.
<28> Nov  6 11:30:08 iscsid: iscsid with pid=1359 started
<28> Nov  6 11:30:09 iscsid: session
[iqn.2005-03.com.max:testdisk,192.168.1.100:3260] already running
<28> Nov  6 11:30:09 iscsid: connection1:0 is operational after recovery (1
attempts)

Esp. the "connection1:0 is operational after recovery (1 attempts)" clearly
indicates that this is not a good thing todo. iscsid is designed as a kernel
helper daemon, which when iscsi is used should be started and never stopped
again.

Note that this means iscsi.startup() also will not get called during the
partitionobjinit step, this is a no-op the first time as then the initiator
name has not been set yet, and if we go back and forth over this step we do not
want to start / stop iscsid, just as we don't want to do that for each iscsi
target added.
---
 partitions.py |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/partitions.py b/partitions.py
index baf8faf..bbd88a6 100644
--- a/partitions.py
+++ b/partitions.py
@@ -54,7 +54,6 @@ def partitionObjectsInitialize(anaconda):
     # shut down all dm devices
     anaconda.id.diskset.closeDevices()
     anaconda.id.diskset.stopMdRaid()
-    anaconda.id.iscsi.shutdown()
     anaconda.id.zfcp.shutdown()
 
     # clean slate about drives
@@ -63,9 +62,6 @@ def partitionObjectsInitialize(anaconda):
     if anaconda.dir == DISPATCH_BACK:
         return
 
-    # ensure iscsi devs are up
-    anaconda.id.iscsi.startup(anaconda.intf)
-
     # ensure zfcp devs are up
     anaconda.id.zfcp.startup()
 
-- 
1.6.0.3


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]