[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] RHEL5.3 fix detection of raid ext4 root partitions



On Fri, Nov 07, 2008 at 07:23:21PM +0100, Radek Vykydal wrote:
> Hi,
>
> this is patch to fix 5.3 bug #470221 - failing search for ext4
> on raid root partitions (concerns upgrade and rescue).
>
> The value of theDev in call fsset.getFStoTry(theDev) made the
> detection fail. Prefixing it with "/dev/" shouldn't break
> anything. It even seems, that several lines below, the call
> isys.readFSLabel(theDev, makeDevNode=0)
> expects device node path, and also lvm part of patched method is using
> node path in theDev.
>
> I tested the patch and I am quite sure about it, but
> there is also another prudent option to add makeDevNode
> parameter to probe methods called by getFStoTry.
>
> Thanks for review,
> Radek
>
>

Looks good to me.

> diff --git a/partedUtils.py b/partedUtils.py
> index b8fc352..98b4b09 100644
> --- a/partedUtils.py
> +++ b/partedUtils.py
> @@ -769,7 +769,7 @@ class DiskSet:
>          for dev, devices, level, numActive in self.mdList:
>              (errno, msg) = (None, None)
>              found = 0
> -            theDev = dev
> +            theDev = "/dev/%s" % dev
>              crypto = self.anaconda.id.partitions.encryptedDevices.get(dev)
>              if crypto and not crypto.openDevice():
>                  theDev = "/dev/%s" % (crypto.getDevice(),)

> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list redhat com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

-- 
David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI

Attachment: pgpMKARreUOQg.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]