[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Prevent traceback for vnc installs on KVM guests (#470559)



On Fri, Nov 07, 2008 at 11:00:53PM -0500, Ignacio Vazquez-Abrams wrote:
> On Fri, 2008-11-07 at 16:12 -1000, David Cantrell wrote: 
> > -    hn = anaconda.id.network.hostname
> > +    try:
> > +        hn = anaconda.id.network.hostname
> > +    except:
> > +        hn = None
> 
> Unfortunately this doesn't explain why you wouldn't get a valid
> hostname. Please consider using "if anaconda.id:" instead.

Why?  I don't understand how 'if anaconda.id:' helps me here.  If
anaconda.id.network.hostname fails for any reason, I want hn to be None.  I
don't see what checking anaconda.id gains me.

-- 
David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI

Attachment: pgpwotoQJqtdh.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]