[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Prevent traceback for vnc installs on KVM guests (#470559)



On Fri, 2008-11-07 at 22:43 -1000, David Cantrell wrote:
> On Fri, Nov 07, 2008 at 11:00:53PM -0500, Ignacio Vazquez-Abrams wrote:
> > On Fri, 2008-11-07 at 16:12 -1000, David Cantrell wrote: 
> > > -    hn = anaconda.id.network.hostname
> > > +    try:
> > > +        hn = anaconda.id.network.hostname
> > > +    except:
> > > +        hn = None
> > 
> > Unfortunately this doesn't explain why you wouldn't get a valid
> > hostname. Please consider using "if anaconda.id:" instead.
> 
> Why?  I don't understand how 'if anaconda.id:' helps me here.  If
> anaconda.id.network.hostname fails for any reason, I want hn to be None.  I
> don't see what checking anaconda.id gains me.

You? Absolutely nothing.

But allow me to ask this. How would someone looking at this know why
network would not have an attribute called hostname?

-- 
Ignacio Vazquez-Abrams <ivazqueznet gmail com>

PLEASE don't CC me; I'm already subscribed

Attachment: signature.asc
Description: This is a digitally signed message part


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]