[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] 470733/452768 - save /etc/fstab on upgrades



On Tue, Nov 11, 2008 at 04:33:15PM -0500, Chris Lumens wrote:
> We now write out a new /etc/fstab on upgrade.  This has the unfortunate
> side effect of any entries anaconda doesn't understand getting dropped.
> After staring at it off and on all day, I can't see any way to fix this
> that doesn't involve lots of fairly invasive changes so instead how
> about if we just backup the fstab before writing out a new one?
> 
> I'm open to other suggestions.

I'm ok with this, at least until we get past this big giant storage rewrite.

> 
> - Chris
> 
> 
> diff --git a/packages.py b/packages.py
> index 371e10e..c141c92 100644
> --- a/packages.py
> +++ b/packages.py
> @@ -101,6 +101,7 @@ def doMigrateFilesystems(anaconda):
>          # if we're upgrading, we may need to do lvm device node hackery
>          anaconda.id.fsset.makeLVMNodes(anaconda.rootPath, trylvm1 = 1)
>          # and we should write out a new fstab with the migrated fstype
> +        shutil.copyfile("%s/etc/fstab" % anaconda.rootPath, "%s/etc/fstab.anaconda" % anaconda.rootPath)
>          anaconda.id.fsset.write(anaconda.rootPath)
>          # and make sure /dev is mounted so we can read the bootloader
>          bindMountDevDirectory(anaconda.rootPath)
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list redhat com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

-- 
David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI

Attachment: pgpySLLWy2t8G.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]