[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Add comps groups for new repos that are added (#470653)



On Wed, 2008-11-12 at 17:11 -0500, Jeremy Katz wrote:
> For new repos that are added, we should also be sure to add their comps
> information to the base comps object.  This largely cut and pastes bits from
> yum's doGroupSetup(), but that can't be done on a per-repo basis.  We should
> add some API, but this will do for now

A couple of important notes:
1) I haven't tested it yet, but wanted to get people's eyes on it
already.  I will test it shortly just to ensure that the right thing is
happening
2) Could arguably just catch all exceptions in the try -- this would be
a little bit safer but also perhaps not as nice.  I've now waffled back
and forth on it enough times that I could have already tested it in the
time I've spent so "to the list" :-)

Jeremy


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]