[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Do not show disabled repos.



On Tue, Nov 18, 2008 at 08:29:43PM -0800, Jesse Keating wrote:
> On Tue, 2008-11-18 at 23:22 -0500, Chris Lumens wrote:
> > 
> > So... why do we want to "fix" this again?  It's like this for a reason -
> > we get the list of repos out of the fedora-release package and do a
> > minimal amount of processing on them to present the list.  I'm not
> > convinced there's anything that needs to be done here.
> 
> Both Notting and Jeremy agree with me that we shouldn't be presenting
> the rawhide repo to users at install time.  The safest way I can think
> of at this point to filter that repo out (and to not be horribly Fedora
> specific) is to just filter out anything that isn't enabled=1.

I don't think we should be making this change, at least at this point in time.
If we don't want specific repos visible in the list, then we should remove the
.repo file from the install.img -or- the fedora-release package should not be
providing them for the F-10 release in the first place.

To me, this seems like putting the fix in the wrong place.  I'll agree that
not displaying the rawhide or updates-testing repo in the list is reasonable
for F-10, but the fix for that shouldn't go in anaconda.  Like Chris said,
we're trying to get away from tying anaconda to specific releases.

-- 
David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI

Attachment: pgpJ5k5NmBDPP.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]