[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 2/7] Fix the case, when the device was removed before partition selection



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed, 2 Dec 2009, Martin Sivak wrote:

---
loader/driverdisk.c |    6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/loader/driverdisk.c b/loader/driverdisk.c
index f718684..074428e 100644
--- a/loader/driverdisk.c
+++ b/loader/driverdisk.c
@@ -404,6 +404,12 @@ int loadDriverFromMedia(int class, struct loaderData_s *loaderData,
            char ** part_list = getPartitionsList(device);
            int nump = 0, num = 0;

+            /* Do not crash if the device disappeared */
+            if(!part_list){
+              stage = DEV_DEVICE;
+              break;
+            }
+
            if (part != NULL) free(part);

            if ((nump = lenPartitionsList(part_list)) == 0) {


This looks fine aside from coding style.

- -- David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAksdaTwACgkQ5hsjjIy1VkkkLwCggLY9c4+mKOd/WsfJ1WxocJT0
WLkAni5FzLIfhH+VzGKBQ/Ql8/Mho0iO
=9K7a
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]