[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 3/5] Enforce GPT on EFI and MSDOS on non-EFI x86 boot disks.



Hi,

On 12/09/2009 09:00 AM, David Lehman wrote:
---
  platform.py |    6 ++++--
  1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/platform.py b/platform.py
index a151de4..261e597 100644
--- a/platform.py
+++ b/platform.py
@@ -223,9 +223,11 @@ class EFI(Platform):
          disk = req.disk.format.partedDisk

          # Check that we've got a correct disk label.
-        if not disk.type in ["gpt", "msdos"]:
-            errors.append(_("%s must have a GPT or MSDOS disk label.") % req.disk.name)
+        if self.isEfi and disk.type != "gpt":
+            errors.append(_("%s must have a GPT disk label.") % req.disk.name)

+        if not self.isEfi and disk.type != "msdos":
+            errors.append(_("%s must have an MSDOS disk label.") % req.disk.name)
          return errors

      def setDefaultPartitioning(self):

I'm not quite sure about this one, GPT disks can have an msdos compatibility table
at the beginning of the disc (created using gptsync), and some EFI machines can boot
from msdos labelled disks.

Peter, do you have any input on this?

Regards,

Hans


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]