[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 3/3] DiskDevice.__init__ expects an "exists" parameter, so add it.



On Tue, 2009-12-15 at 17:04 -0500, Chris Lumens wrote:
> ---
>  storage/devices.py |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/storage/devices.py b/storage/devices.py
> index 1598497..62bebd0 100644
> --- a/storage/devices.py
> +++ b/storage/devices.py
> @@ -728,7 +728,8 @@ class DiskDevice(StorageDevice):
>  
>      def __init__(self, device, format=None,
>                   size=None, major=None, minor=None, sysfsPath='',
> -                 parents=None, serial=None, vendor="", bus=""):
> +                 parents=None, serial=None, vendor="", bus="",
> +                 exists=True):
>          """ Create a DiskDevice instance.
>  
>              Arguments:
> @@ -752,7 +753,7 @@ class DiskDevice(StorageDevice):
>              DiskDevices always exist.
>          """
>          StorageDevice.__init__(self, device, format=format, size=size,
> -                               major=major, minor=minor, exists=True,
> +                               major=major, minor=minor, exists=exists,
>                                 sysfsPath=sysfsPath, parents=parents,
>                                 serial=serial, vendor=vendor, bus=bus)
>  

How can this be necessary? DiskDevice instances always exist since we do
not have the ability to create them.

If MultipathDevice instances are being created with exists=False (could
be a separate matter entirely) the problem is that we aren't passing
exists=True to the ctor from DeviceTree.handleMultipathMemberFormat.

Dave



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]