[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] DriverDiscs again - fixes according to review

On Tue, 8 Dec 2009, Martin Sivak wrote:


I tried to fix most of the stuff you guys came up during review. But there are some places where I didn't. Let me explain why.

- I'm not moving to libarchive before it gets commited. We need testing time and rewriting stuff again and again just doesn't help with that. The code doesn't even get called during the normal user anaconda usage and can be replaced later.

I guess I'm confused here.  Your next point down you want libraries for rpm.
But you are opposed to it for cpio?  Really, using libarchive is only
necessary if cpio access is necessary inside the loader.  I'm just confused as
to why you don't want to use it for cpio reading but do want to use librpm for
working with rpms.

- I see no point in using rpm binary directly.. we use libraries everywhere and we actually moved from iscsiadm to -liscsi as soon as it was possible. So I just do not understand why the strong objection to this particular API.. Moreover as I said in the review, I need more than just unpacking RPMs.

What else is needed beyond unpacking the RPMs?  That's probably where my
misunderstanding is.  I'm under the impression that we simply need to unpack
the RPM, pull out the .ko files, and let modprobe load them so we can use
those devices during installation.  Is there more?

- Older code update / static buffers .. I updated string handling in all the code which is used right now. Getting module info is not called anywhere atm, so I'll fix it during testing.


- For the rest: We can add Anaconda loader cleanup to Wiki and make it another goal. Now it's just not the right time.

Anaconda loader cleanup has been on the to do list since I've been at Red Hat,
and we still see msw, ewt, and msf code.  We'll never get around to it unless
we actually force cleanup.  Since this was largely new code entering the
installer, it felt like as good a time as any.  I don't think any of the
cleanups pointed out were very difficult.

I'd like to see comments from other people on the team regarding the driver
disk patch set.

David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]