[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 1/2] display reIPL information via lsreipl



clumens redhat com wrote on 12/16/2009 10:12:13 AM:

> Please don't catch the top-level Exception.  If you are expecting a
> specific exception, catch that.  Otherwise, what are you expecting to
> happen here?

During development of this, an Exception was thrown by execWithRedirect.
This caused installation to fail.  Which is why I added the catch.
I don't remember the exact exception.  However, as this is only informational,
I really don't want an exception to abort the installation.

Obviously, the executable can be corrupted, or not have correct permissions,
or have a run time problem.  I didn't know the complete list of possible
exceptions, so I caught the parent.

I can remove the exception if you want...

--
Mark

You must be the change you wish to see in the world. -- Mahatma Gandhi
Worrying is praying for that you do not wish to happen.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]