[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 6/7] Use the updated DriverDisc code in loader

On 12/17/2009 12:21 PM, Chris Lumens wrote:
>> @@ -1882,6 +1887,12 @@ int main(int argc, char ** argv) {
>>      flags |= LOADER_FLAGS_NOSHELL;
>>  #endif
>> +    /* XXX if RHEL, enable the AUTODD feature by default,
>> +     * but we should come with more general way how to control this */
>> +    if (!strncmp(getProductName(), "Red Hat", 7)) {
>> +        flags |= LOADER_FLAGS_AUTOMODDISK;
>> +    }
>> +
>>      openLog(FL_TESTING(flags));
>>      if (!FL_TESTING(flags))
>>          openlog("loader", 0, LOG_LOCAL0);
> I can't think of a better way to do this in the loader, unfortunately.
> We're making things harder on redistributers like Centos.  There, it's
> going to be disabled by default whereas on RHEL, it'll be enabled by
> default.  So, derived distributions will function differently than the
> original.
> Still, I can't think of a better way.

I can think of another way - but we might want to discuss it with rel-eng,
because it'd require compose tools to change.

Basically, we could add a line to .buildstamp that behaves kindof like the "flags"
line in /proc/cpuinfo , ie something like "features: automoddisk" or
"features: noautomoddisk" to turn defaults for flags on and off at /compose/ time.
Then we'd process that line in loader between our built-in defaults and the
command line parsing.

It's probably best to work on that as a separate feature independent of this.


I number the Linux folks among my personal heroes.
		-- Donald Knuth

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]