[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [master] Log into program.log through the standard python logging (part of #524980).



> @@ -57,7 +55,7 @@ class tee(threading.Thread):
>              if data == "":
>                  self.running = False
>              else:
> -                self.file.write(data)
> +                self.log.debug(data.rstrip('\n'))
>                  os.write(self.outputdesc, data)
>  
>      def stop(self):

I think I might raise the level of the program's output to info for two
reasons:

(1) It just seems informational to me.  debug is more like for figuring
out what's gone wrong (or just what's going on) with anaconda, not
really for other programs.

(2) It gives you another lower level to work with, so in case you want
to start getting debug output that you don't want everyone to see you
can do that without needing to make more changes.

Otherwise, ACK.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]