[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 4/5] For iSCSI devices, put the path into the UI instead of a WWID.



On Fri, 2009-12-18 at 14:41 -0500, Chris Lumens wrote:
> ---
>  iw/filter_gui.py |   11 +++++++++--
>  1 files changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/iw/filter_gui.py b/iw/filter_gui.py
> index b540621..46c26c8 100644
> --- a/iw/filter_gui.py
> +++ b/iw/filter_gui.py
> @@ -547,11 +548,17 @@ class FilterWindow(InstallWindow):
>              partedDevice = parted.Device(path="/dev/" + udev_device_get_name(d))
>              d["XXX_SIZE"] = int(partedDevice.getSize())
>  
> +            # This isn't so great, but for iSCSI devices the path contains a lot
> +            # of useful identifiying info that should be displayed.
> +            if udev_device_is_iscsi(d):
> +                id = udev_device_get_path(d)
> +            else:
> +                id = udev_device_get_wwid(d)

Are you okay with clobbering the built-in function id?

Dave


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]