[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 4/5] For iSCSI devices, put the path into the UI instead of a WWID.



On 12/18/2009 08:41 PM, Chris Lumens wrote:
> ---
>  iw/filter_gui.py |   11 +++++++++--
>  1 files changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/iw/filter_gui.py b/iw/filter_gui.py
> index b540621..46c26c8 100644
> --- a/iw/filter_gui.py
> +++ b/iw/filter_gui.py

> @@ -547,11 +548,17 @@ class FilterWindow(InstallWindow):
>              partedDevice = parted.Device(path="/dev/" + udev_device_get_name(d))
>              d["XXX_SIZE"] = int(partedDevice.getSize())
> 
> +            # This isn't so great, but for iSCSI devices the path contains a lot
> +            # of useful identifiying info that should be displayed.
> +            if udev_device_is_iscsi(d):
> +                id = udev_device_get_path(d)
> +            else:
> +                id = udev_device_get_wwid(d)
> +
>              tuple = (d, True, False, udev_device_get_name(d),
>                       partedDevice.model, str(d["XXX_SIZE"]) + " MB",
>                       udev_device_get_vendor(d), udev_device_get_bus(d),
> -                     udev_device_get_serial(d), udev_device_get_wwid(d),
> -                     "", "", "", "")
> +                     udev_device_get_serial(d), id, "", "", "", "")
>              _addTuple(tuple)
> 
>          for rs in block.getRaidSets():

Since I don't have any rawhide build for s390x, I have to guess based on
the mockups in the wiki that this is about the column WWID of the "Other
SAN Devices" notetab for Advanced Device Selection. In other words, not
for multipath devices, where the WWID seems certainly the right identifier.

The same things as for iSCSI device paths applies for DASD and zFCP.
/dev/disk/by-path/... contains exactly those identifiers, under which
users of s390x uniquely identify their disks at a glance. It would be a
great usability improvement, if you could also show the path instead of
the WWID for DASD and zFCP.

See also:
https://fedoraproject.org/wiki/User:Pjones/StorageDeviceIdentification
and some example commits, which use by-path for DASD and/or zFCP LUNs:
9d8bbfa47b2145e51d9453311801863a6b4509f6
7e220fa8a708acbdd8c4fb4865d9bf589bd065bd
cc7d403c2c338c0d71de0bca8ff9b316b336a6b2

Steffen

Linux on System z Development

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]