[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Moving anaconda to autoconf/automake

> This was a backburner project I had for a while, but I've updated it to  
> work with the latest source tree and feel now (early in F-12), it's a  
> good time to look at something like this.

I'm okay with this, if for no other reason than:

(1) It forces some sort of build system organization on us, which we had
    kind of been making up as we went along.

(2) It makes us look more like all the other projects in Fedora, which
    is at the least good PR for us.

(3) It forces us to look at our source tree and move things around that
    no longer make sense.

> The patch is large, but I've run it through splitdiff so you can look at
> each file change:
>     http://dcantrel.fedoraproject.org/anaconda/autognu/

If you end up committing, I'd prefer to see it broken up finer grained
than the one mega patch, but not as much as one patch per file.  I like
patches that accomplish one specific task.  So, a patch that creates a
bunch of stuff in m4/, a patch that moves things around in liveinst/,
etc.  That's a little easier to digest in the source history.

> 4) Speaking of ./configure, I added options for SELinux and other things
>    that we had as conditionals in Makefiles (however, they may no longer
>    be completely conditional in the code).  The default settings are
>    what we had as defaults before.

At some point, we should go through and decide whether these things
really do need to be options anymore.

> 6) The 'make rpmlog' target adds changelog data to anaconda.spec.in.  I
>    also removed changelog data older than Jan 1, 2008.

Good.  This should also close 492436 then.

> 8) Library function and header tests are in configure.ac.  We can expand
>    these as much as we want as find ourselves fighting with various
>    library version differences.

Also good.  Hopefully these will prove themselves to be useful.

> 9) The release procedure will be slightly different using
>    autoconf/automake.  You will need to run ./bootstrap, then
>    ./configure, make bumpver, commit, make dist.  The READ_ME.txt file
>    at the URL above explains it.

Annoying, but I think we're all used to it by now.

- Chris

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]