[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Moving anaconda to autoconf/automake

On 06/09/2009 08:07 AM, Chris Lumens wrote:
If you end up committing, I'd prefer to see it broken up finer grained
than the one mega patch, but not as much as one patch per file.  I like
patches that accomplish one specific task.  So, a patch that creates a
bunch of stuff in m4/, a patch that moves things around in liveinst/,
etc.  That's a little easier to digest in the source history.

I broke it up in to 25 commits divided up by subdirectory and/or topic (e.g., the liveinst restructure). It's still sort of an all-or-nothing thing. But at least the history is easier to read.

4) Speaking of ./configure, I added options for SELinux and other things
    that we had as conditionals in Makefiles (however, they may no longer
    be completely conditional in the code).  The default settings are
    what we had as defaults before.

At some point, we should go through and decide whether these things
really do need to be options anymore.

Yes, I can see SELinux maybe being conditional. Apparently NFS is/was(???) conditional at one point.

6) The 'make rpmlog' target adds changelog data to anaconda.spec.in.  I
    also removed changelog data older than Jan 1, 2008.

Good.  This should also close 492436 then.


David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]