[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Enable support for bootloader on md RAID1 partitions.

Hans de Goede wrote:

Ah, good catch, looking further I cannot help but notice, that for the
other use of gtPart, one can just as well use bootDev, as getMatchingPart()
searches for the first physical device which is on the same disk
as bootDev, and then we use getDiskPart() to get only the diskname, so
if we just pass in gtPart directly, nothing changes.

I was looking at this, because if we do this, we can then get rid of
the gtPart variable and of the getMatchingPart() method (which
seems to be a bullshit method anyways).

Yes, I was thinking the same but I wanted to keep this patch initial/simple,
expecting discussion about whether we really want to start to install grub on
md raid1 boot partitions.

+ elif path.startswith('md') and not flags.cmdline.has_key("iswmd"):
+ target = "partition"

I'm afraid this check is not 100% bullet proof, when we have the
key iswmd, we can still be installing grub on a partition, or despite
the presence of the flag, the mdraid device node path, may actually point
to a regular mdraid set, not one using isw metadata.

You are right, maybe this kind check (i.e. for iswmd) should go somewhere
to partitioning and/or bootloader selection so that this part of code can expect
grub target /dev/md* to be regular md raid 1.

Thanks for the review.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]