[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Add cdroms and other non-partition based devices to blkid database (#485060)



Hi,

On 11/09/2009 02:33 PM, Steffen Maier wrote:
On 11/09/2009 02:13 PM, Hans de Goede wrote:
On 11/09/2009 01:58 PM, Martin Sivak wrote:
---
   loader2/driverdisk.c |   24 ++++++++++++++++++++++++
   1 files changed, 24 insertions(+), 0 deletions(-)

diff --git a/loader2/driverdisk.c b/loader2/driverdisk.c
index eca8605..298c896 100644
--- a/loader2/driverdisk.c
+++ b/loader2/driverdisk.c
@@ -600,6 +604,26 @@ struct ddlist* findDriverDiskByLabel(void)
       logMessage(ERROR, _("Cannot initialize cache instance for blkid"));
       return NULL;
       }
+
+    /* List all block devices from /sys/block and add them to blkid db
+     * libblkid should be doing that, so lets consider this as a workaround */
+    sysblock = opendir("/sys/block");
+    if(sysblock){
+      while((direntry = readdir(sysblock))!=NULL){
+    /* add only h(d?), s(d?), z(fcp) devices */

scsi cdroms are scd? not sd?, also zfcp attached storage shows up as
regular scsi devices (sd? scd?), so no need to check for those (my bad).

Since I cannot access the mentioned bug, I don't know anything about the
background and what the goal is. According to the directory name, this
seems to be some older branch, probably RHEL5. Anyway, if all block
devices should be catched, you may want to also search for devices with
prefix "dasd" to get s390 disk devices. Hans is right that zfcp-attached
  block devices appear as regular scsi block devices.


Steffen,

Yes this is RHEL-5, but we are only looking for disks which may contain
driver disks, and AFAIK a dasd have never been used as a driver disk source.

Regards,

Hans
=


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]