[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 4/4] Honor existing RUNKS conf file variable on s390 (#513951).



On Mon, Nov 9, 2009 at 9:39 PM, David Cantrell <dcantrell redhat com> wrote:
> On Mon, 9 Nov 2009, Jeremy Katz wrote:
>> On Mon, Nov 9, 2009 at 6:47 PM, David Cantrell <dcantrell redhat com> wrote:
>>> The linuxrc.s390 rewrite changed the behavior of RUNKS on RHEL-5.  We've
>>> done away with RUNKS on RHEL-6, but we still need to maintain existing
>>> functionality on RHEL-5.
>>
>> To minimize the deltas between RHEL5 and RHEL6, would it make sense to
>> just have something like
>>  if [ "$RUNKS" = "0" ]; then RUNKS="" ; fi
>> at the top of the script?
>>
>> Looks fine in any case, just minor nitpicking to save effort on
>> keeping the two in sync.
>
> Yeah, how about:

Looks great tom e

- Jeremy


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]