[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Set boot flag for /boot on mdraid 1 array too (#533533).



> >---
> >  storage/__init__.py |   17 ++++++++++++-----
> >  1 files changed, 12 insertions(+), 5 deletions(-)
> >
> >diff --git a/storage/__init__.py b/storage/__init__.py
> >index 70c3227..4e911ed 100644
> >--- a/storage/__init__.py
> >+++ b/storage/__init__.py
> >@@ -281,13 +281,20 @@ class Storage(object):
> >          # now set the boot partition's flag
> >          try:
> >              boot = self.anaconda.platform.bootDevice()
> >+            if boot.type == "mdarray":
> >+                bootDevs = [self.devicetree.getDeviceByName(x) for x in
> >+                            self.anaconda.id.bootloader.getPhysicalDevices(boot.name)]
> 
> Why not just use boot.parents ? The getPhysicalDevices() thingy in booty is a leftover
> from older times, which one day we should get rid of, not use more often :)

Agreed - note that right now, storage has no knowledge of bootloader:

   clumens localhost:~/src/anaconda/storage$ grep -r bootloader *
   clumens localhost:~/src/anaconda/storage$ 

We need to keep it that way.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]