[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [rhel5-branch] kickstart option to make mpath0 point to arbitrary LUN (#502768)



> +                        # In case of mpathNNNpMMM, we only want 'mpathNNN' where 
> +                        # NNN is an int, strip all trailing subdivisions of mpathNNN
> +                        mpregex = "(?<=^%s).*$" % mpdev
> +                        trail = re.search(mpregex, mpathname)

I know this was in the code before being patched, but that's a pretty
awful regex.  Can you come up with a way to make this more readable?

> @@ -1624,6 +1639,14 @@ class YumBackend(AnacondaBackend):
>  
>                  f.write('}\n\n')
>  
> +                for (mpathname, id) in wwids:
> +                    if(mpathname.find("mpath") == -1):
> +                        # this mpath device was renamed 
> +                        f.write('\nmultipath {\n')
> +                        f.write("        wwid \"%s\"\n" % (id,))
> +                        f.write("        alias \"%s\"\n" % (mpathname,)) 
> +                        f.write('}\n\n')
> +
>              f.close()
>  
>      def checkSupportedUpgrade(self, anaconda):

The fact that all this stuff is just sitting in doPreInstall is dire,
but there's nothing we can do about that now.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]