[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 6/6] Remove the early kickstart processing pass (#532453).



On Wed, 2009-11-11 at 13:43 -0500, Chris Lumens wrote:
> Among other problems, this means that all the partitioning commands can be
> in a file generated from a %pre script again.

I don't claim that I fully understand all of this, but it looks
reasonable to me with one exception (noted below).

> ---
>  anaconda     |   75 +++++++++++++++++++++++++++--------------------
>  kickstart.py |   92 +++++++++++++--------------------------------------------
>  2 files changed, 64 insertions(+), 103 deletions(-)
> 
> diff --git a/anaconda b/anaconda
> index 0dc5238..63cc35f 100755
> --- a/anaconda
> +++ b/anaconda 
> @@ -794,16 +787,17 @@ if __name__ == "__main__":
>  
>          anaconda.id = instdata.InstallData(anaconda, [], opts.display_mode)
>  
> -        if opts.ksfile:
> +        if anaconda.isKickstart:
>              instClass.setInstallData(anaconda)
> +            anaconda.id.setKsdata(ksdata)
>  
> -            #we need waitWindow valid in processKickstartFile. because storage uses it
> +            # We need an interface before running kickstart apply methods for
> +            # storage.
>              from snack import *
>              screen = SnackScreen()
>              anaconda.intf = rescue.RescueInterface(screen)
>  
> -            kickstart.preScriptPass(anaconda, opts.ksfile)
> -            kickstart.fullCommandPass(anaconda, opts.ksfile, earlyKS)
> +            ksdata.handler.apply()

I think you used "execute" everywhere else and "apply" here (and in the
commit log).

Dave



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]