[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] 537390: reIPL is calculating the boot drive incorrectly



On 11/18/2009 01:33 AM, David Cantrell wrote:
> I went ahead and made these changes and pushed the resulting patch since
> you said you were going on vacation starting Nov 18th.

> On Tue, 17 Nov 2009, Mark Hamzy wrote:
>> This time with fixes from Chris.  Note that the linuxrc fix is just
>> informative at the end of an install and before a reboot occurs...

>> diff --git a/loader/linuxrc.s390 b/loader/linuxrc.s390
>> index d50dcbd..71e4d0e 100644
>> --- a/loader/linuxrc.s390
>> +++ b/loader/linuxrc.s390
>> @@ -95,6 +95,16 @@ function doshutdown()
>>
>> function doreboot()
>> {
>> +    if [ -e "/sys/firmware/reipl" ]; then
>> +     read REIPL_TYPE < /sys/firmware/reipl/reipl_type
>> +     echo "reipl_type=$REIPL_TYPE"
>> +     pushd /sys/firmware/reipl/$REIPL_TYPE >/dev/null 2>&1

I see two problems with the informative code. First, anaconda supports
the two reipl types ccw for DASD and fcp for zFCP. The kernel interface
also supports other stuff such as nss (named saved segments). I think we
should only descend into the reipl type specific subdirectory and get
additional information for the two types anaconda supports because
anaconda does not know anything about the other types and how to
interpret their information. Which is fine, BTW, since those types are
not needed for installation.

>> +     for i in *; do
>> +         echo "$i=`cat $i`"

I'm not sure, if all sysfs attributes will always contain printable
ASCII text. I wouldn't want any potential binary data misconfigure the
console. Maybe a hexdump (e.g. od -xa) of the attributes' content would
make this safer?

>> +     done
>> +     popd >/dev/null 2>&1
>> +    fi
>> +
>>     echo $"about to exec shutdown -r"
>>     exec /sbin/shutdown -r
>>     exit 0

Steffen

Linux on System z Development

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]