[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 3/3] Enhance drive specification for clearpart, ignoredisk, and partition.



On Thu, 2009-11-19 at 17:05 -0500, Chris Lumens wrote:
> Now you can use globs or non-device node names to specify disks in the
> arguments to these commands, which should be a big help to large storage
> configurations.
> ---
>  kickstart.py |  100 ++++++++++++++++++++++++++++++++++++++--------------------
>  1 files changed, 66 insertions(+), 34 deletions(-)
> 
> diff --git a/kickstart.py b/kickstart.py
> index 7735439..dd023ae 100644
> --- a/kickstart.py
> +++ b/kickstart.py
> @@ -156,6 +156,17 @@ def getEscrowCertificate(anaconda, url):
>          f.close()
>      return anaconda.id.escrowCertificates[url]
>  
> +def deviceMatches(spec):
> +    matches = udev_resolve_glob(spec)
> +    dev = udev_resolve_devspec(spec)
> +
> +    # udev_resolve_devspec returns None if there's no match, but we don't
> +    # want that ending up in the list.
> +    if dev:
> +        matches.append(dev)

Shouldn't the above be something like 'if dev and dev not in matches:'
instead?

Also, about the udev_trigger... it would be nice if we could only do
that as often as is really necessary, especially for larger systems, but
that probably doesn't rank very high among our other sins.

Looks fine in general.

Dave


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]