[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 2/4] Remove loader from the reboot/shutdown/halt picture.



On 11/24/2009 02:41 PM, Steffen Maier wrote:
> comment inline
> 
> On 11/23/2009 09:40 PM, Chris Lumens wrote:
>> Right now, rebooting/halting after installation is handled in at least
>> three places:  anaconda knows how to do some things, loader knows how to do
>> some others, and init knows how to do everything.  loader really just does a
>> bunch of signal handling and process exit status checking to figure out how
>> to signal init which is completely unnecessary.  Instead, loader should just
>> exec anaconda and then get out of the picture.
>> ---
>>  loader/loader.c |   68 +++---------------------------------------------------
>>  1 files changed, 4 insertions(+), 64 deletions(-)
>>
>> diff --git a/loader/loader.c b/loader/loader.c
>> index cd3e178..5502553 100644
>> --- a/loader/loader.c
>> +++ b/loader/loader.c

>> @@ -2263,44 +2234,13 @@ int main(int argc, char ** argv) {

>> -#if defined(__s390__) || defined(__s390x__)
>> -        /* at the latest possibility signal init=linuxrc.s390 to reboot/halt */
>> -        logMessage(INFO, "Sending signal %d to process %d\n",
>> -                   init_sig, init_pid);
>> -        kill(init_pid, init_sig);
>> -#endif
> 
> I guess util.py:reIPLtrigger() would now have to call init
> (=linuxrc.s390) as reboot or halt instead of killing its parent loader
> with SIGUSR2 or SIGUSR1.

Sorry, I just realized that this would prematurely kill the installation
process. Up to now we relied on loader deferring the init signalling for
shutdown to the latest point which is after anaconda terminated. From
the top of my head I currently have no idea for how to solve this.
Reipl just needs some way for anaconda to dynamically tell init whether
it should reboot or halt.

Steffen

Linux on System z Development

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]