[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Don't attempt to get the size of a filesystem unless it's supported (#540598).



On Tue, 2009-11-24 at 11:30 -0500, Chris Lumens wrote:
> We're not guaranteed to have the _infofs program on every platform, so we
> need to make sure the filesystem is supported before making an attempt.  For
> now this is only showing up on NTFS volumes on ppc, but it's possible to
> come up in other places.

Looks okay. I think that the current size is unimportant for unsupported
filesystem types (no resize, for one thing), so this should not cause
problems.

Dave

> ---
>  storage/formats/fs.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/storage/formats/fs.py b/storage/formats/fs.py
> index 12f624f..63a116b 100644
> --- a/storage/formats/fs.py
> +++ b/storage/formats/fs.py
> @@ -150,7 +150,7 @@ class FS(DeviceFormat):
>          self._size = kwargs.get("size", 0)
>          self._minInstanceSize = None    # min size of this FS instance
>          self._mountpoint = None     # the current mountpoint when mounted
> -        if self.exists:
> +        if self.exists and self.supported:
>              self._size = self._getExistingSize()
>              foo = self.minSize      # force calculation of minimum size
>  


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]