[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Add DCB option to text mode FCoE setup (#513011)



On 11/27/2009 01:52 AM, Jeremy Katz wrote:
On Thu, Nov 26, 2009 at 6:20 AM, Hans de Goede<hdegoede redhat com>  wrote:
@@ -232,7 +233,15 @@ class PartitionTypeWindow:
-        self.anaconda.id.storage.fcoe.addSan(nic)
+        dcb = entries[1].strip().lower()
+        if dcb != _("yes").lower() and dcb != _("no").lower():

Expecting lower to work like this breaks for some languages (eg,
Icelandic).  If this is an entry which should be either yes or no, we
really should have it be as a radio button/checkbox rather than an
entry

- Jeremy


Yep,

I was afraid of this as well but couldn't come up with a language as an example. Now we know.

Ales


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]