[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Add DCB option to text mode FCoE setup (#513011)



On Fri, Nov 27, 2009 at 3:07 AM, Hans de Goede <hdegoede redhat com> wrote:
> On 11/27/2009 01:52 AM, Jeremy Katz wrote:
>> On Thu, Nov 26, 2009 at 6:20 AM, Hans de Goede<hdegoede redhat com  wrote:
>>> @@ -232,7 +233,15 @@ class PartitionTypeWindow:
>>> -        self.anaconda.id.storage.fcoe.addSan(nic)
>>> +        dcb = entries[1].strip().lower()
>>> +        if dcb != _("yes").lower() and dcb != _("no").lower():
>>
>> Expecting lower to work like this breaks for some languages (eg,
>> Icelandic).  If this is an entry which should be either yes or no, we
>> really should have it be as a radio button/checkbox rather than an
>> entry
>>
> Ugh, can you point to some example code in the textw interface
> where a checkbox is used in some simple way, or do need to write
> a custom screen for this ?

netconfig_text has some.  newt really isn't hard for simple things :)

- Jeremy


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]